Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove if DEBUG check for sltp functionality, use abacus feature flag for reduce only #163

Merged
merged 2 commits into from
May 13, 2024

Conversation

mike-dydx
Copy link
Contributor

Description / Intuition

  • removed the if DEBUG check for enabling sltp and sltp on limit orders. Now driven by abacus/env feature flag
  • reading reduceOnly from abacus feature flags instead of feature flags json

Before/After Screenshots or Videos

Before After

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@mike-dydx mike-dydx merged commit a372864 into develop May 13, 2024
2 checks passed
@mike-dydx mike-dydx deleted the mike/update-sltp-ff branch May 13, 2024 20:08
mike-dydx added a commit that referenced this pull request Aug 20, 2024
…ag for reduce only (#163)

* remove if DEBUG checks that block new sltp UI

* reduce only feature flag driven by env.json
mike-dydx added a commit that referenced this pull request Aug 21, 2024
…ag for reduce only (#163)

* remove if DEBUG checks that block new sltp UI

* reduce only feature flag driven by env.json
mike-dydx added a commit that referenced this pull request Aug 21, 2024
…ag for reduce only (#163)

* remove if DEBUG checks that block new sltp UI

* reduce only feature flag driven by env.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants