MOB-357 Margin Mode Selection Screen #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dydx/dydxPresenters/dydxPresenters/_Features/routing_swiftui.json # dydx/dydxPresenters/dydxPresenters/_v4/Trade/Margin/dydxMarginModeViewBuilder.swift # dydx/dydxPresenters/dydxPresenters/_v4/Trade/TradeInput/Components/TradeInputFields/dydxTradeInputMarginViewPresenter.swift # dydx/dydxViews/dydxViews/_v4/Trade/Margin/dydxMarginModeView.swift
johnqh
approved these changes
May 9, 2024
mike-dydx
pushed a commit
that referenced
this pull request
Aug 20, 2024
* MOB-483 Add isolated / cross margin mode button, Add target leverage button * MOB-357 Margin Mode Selection Screen
mike-dydx
pushed a commit
that referenced
this pull request
Aug 21, 2024
* MOB-483 Add isolated / cross margin mode button, Add target leverage button * MOB-357 Margin Mode Selection Screen
mike-dydx
pushed a commit
that referenced
this pull request
Aug 21, 2024
* MOB-483 Add isolated / cross margin mode button, Add target leverage button * MOB-357 Margin Mode Selection Screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: [Provide link to Linear ticket issue]
Figma Design: [Provide link to Figma design here if applicable]
Description / Intuition
Adding Margin Mode Selection Screen. UI only.
Before/After Screenshots or Videos
Type of Change