MOB-456 : integrate abacus validation error with button states #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dydx
force-pushed
the
mike/mob-456-integrate-abacus-validation-error-with-button-states
branch
from
4e99e55 to
5ccdcab
Compare
mike-dydx
commented
Apr 23, 2024
| @@ -171,6 +165,8 @@ private class dydxTakeProfitStopLossViewPresenter: HostedViewPresenter<dydxTakeP | |||
| viewModel?.takeProfitStopLossInputAreaViewModel?.stopLossPriceInputViewModel?.value = dydxFormatter.shared.raw(number: triggerOrdersInput?.stopLossOrder?.price?.triggerPrice?.doubleValue, digits: 2) | |||
| viewModel?.takeProfitStopLossInputAreaViewModel?.lossInputViewModel?.value = dydxFormatter.shared.raw(number: triggerOrdersInput?.stopLossOrder?.price?.usdcDiff?.doubleValue, digits: 2) | |||
|
|
|||
| viewModel?.customAmountViewModel?.value = triggerOrdersInput?.size?.doubleValue.magnitude.stringValue | |||
There was a problem hiding this comment.
fixes manual input issue mentioned in description
ruixhuang
reviewed
Apr 23, 2024
| @@ -187,7 +183,8 @@ private class dydxTakeProfitStopLossViewPresenter: HostedViewPresenter<dydxTakeP | |||
| } | |||
|
|
|||
| if let error = errors.first { | |||
| viewModel?.submissionReadiness = .fixErrors(cta: error.resources.action?.localized) | |||
| let errorCta = error.resources.action?.localized ?? DataLocalizer.shared?.localize(path: error.resources.action?.stringKey ?? "", params: nil) | |||
There was a problem hiding this comment.
There is an extension to use:
extension ErrorString { var localizedString: String? { localized ?? DataLocalizer.localize(path: stringKey, params: params?.dictionary) } }
There was a problem hiding this comment.
addressed d8051ac
ruixhuang
reviewed
Apr 23, 2024
| @@ -295,6 +292,7 @@ private class dydxTakeProfitStopLossViewPresenter: HostedViewPresenter<dydxTakeP | |||
| AbacusStateManager.shared.triggerOrders(input: $0, type: .stoplossusdcdiff) | |||
| } | |||
| viewModel.customAmountViewModel?.onEdited = { | |||
| print("mmm: custom amount edited \($0)") | |||
There was a problem hiding this comment.
i'll do a clean up PR at the end of the project. There's many other print statements i need to get rid of. Omitted anyways d8051ac
mike-dydx
force-pushed
the
mike/mob-456-integrate-abacus-validation-error-with-button-states
branch
from
260a94a to
d8051ac
Compare
ruixhuang
approved these changes
Apr 23, 2024
mike-dydx
deleted the
mike/mob-456-integrate-abacus-validation-error-with-button-states
branch
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
* bump 1.6.36 -> 1.6.38 * some ui * add label accessory to platform input, split out input views into view models * clean up * add cta button * hook up button and button states * abacus? * clean up * pause * clean up * pause * fix keyboard, fix toggle clipping, fix trade input not scrollable * bump 1.6.36 -> 1.6.38 * some ui * add label accessory to platform input, split out input views into view models * clean up * add cta button * hook up button and button states * abacus? * clean up * pause * clean up * fix keyboard, fix toggle clipping, fix trade input not scrollable * clean up * clean up * bump 1.6.36 -> 1.6.38 * some ui * add label accessory to platform input, split out input views into view models * clean up * add cta button * hook up button and button states * abacus? * clean up * pause * clean up * pause * fix keyboard, fix toggle clipping, fix trade input not scrollable * clean up * clean up * add validation error handling * use localized string extension for validation error
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* bump 1.6.36 -> 1.6.38 * some ui * add label accessory to platform input, split out input views into view models * clean up * add cta button * hook up button and button states * abacus? * clean up * pause * clean up * pause * fix keyboard, fix toggle clipping, fix trade input not scrollable * bump 1.6.36 -> 1.6.38 * some ui * add label accessory to platform input, split out input views into view models * clean up * add cta button * hook up button and button states * abacus? * clean up * pause * clean up * fix keyboard, fix toggle clipping, fix trade input not scrollable * clean up * clean up * bump 1.6.36 -> 1.6.38 * some ui * add label accessory to platform input, split out input views into view models * clean up * add cta button * hook up button and button states * abacus? * clean up * pause * clean up * pause * fix keyboard, fix toggle clipping, fix trade input not scrollable * clean up * clean up * add validation error handling * use localized string extension for validation error
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* bump 1.6.36 -> 1.6.38 * some ui * add label accessory to platform input, split out input views into view models * clean up * add cta button * hook up button and button states * abacus? * clean up * pause * clean up * pause * fix keyboard, fix toggle clipping, fix trade input not scrollable * bump 1.6.36 -> 1.6.38 * some ui * add label accessory to platform input, split out input views into view models * clean up * add cta button * hook up button and button states * abacus? * clean up * pause * clean up * fix keyboard, fix toggle clipping, fix trade input not scrollable * clean up * clean up * bump 1.6.36 -> 1.6.38 * some ui * add label accessory to platform input, split out input views into view models * clean up * add cta button * hook up button and button states * abacus? * clean up * pause * clean up * pause * fix keyboard, fix toggle clipping, fix trade input not scrollable * clean up * clean up * add validation error handling * use localized string extension for validation error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: MOB-456 : integrate abacus validation error with button states
Figma Design: https://www.figma.com/file/mKevZOfE9nj6MZpiolKYW1/dYdX-%E2%80%BA-Mobile?type=design&node-id=5621-14141&mode=design&t=8620ZeK9v5G9SIV4-4
Description / Intuition
Before/After Screenshots or Videos
Simulator.Screen.Recording.-.iPhone.15.-.2024-04-22.at.20.19.07.mp4
Simulator.Screen.Recording.-.iPhone.15.-.2024-04-22.at.20.15.04.mp4
Type of Change