MOB-430 : support error states for TP/SL inputs #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dydx
force-pushed
the
mike/mob-428-add-custom-amount-to-price-triggers-screen
branch
from
1d78173 to
2ca282d
Compare
mike-dydx
changed the title
mike-dydx
force-pushed
the
mike/mob-428-add-custom-amount-to-price-triggers-screen
branch
2 times, most recently
from
815da0b to
f1e425c
Compare
mike-dydx
force-pushed
the
mike/mob-428-add-custom-amount-to-price-triggers-screen
branch
from
f1e425c to
1c3c3c0
Compare
ruixhuang
approved these changes
Apr 10, 2024
mike-dydx
deleted the
mike/mob-428-add-custom-amount-to-price-triggers-screen
branch
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
* some ui * add label accessory to platform input, split out input views into view models * update advanced font * touch up UI * clean up * add in-line alert UI
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* some ui * add label accessory to platform input, split out input views into view models * update advanced font * touch up UI * clean up * add in-line alert UI
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* some ui * add label accessory to platform input, split out input views into view models * update advanced font * touch up UI * clean up * add in-line alert UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: MOB-430 : support error states for TP/SL inputs
Figma Design: https://www.figma.com/file/mKevZOfE9nj6MZpiolKYW1/dYdX-%E2%80%BA-Mobile?type=design&node-id=5621-14141&mode=design&t=MeYotwfkGOffPavy-4
Description / Intuition
Before/After Screenshots or Videos
Simulator.Screen.Recording.-.iPhone.15.-.2024-04-08.at.16.40.55.mp4
Type of Change