Skip to content

Commit

Permalink
TRCL-3496 Reduce Profile->History tab height (#63)
Browse files Browse the repository at this point in the history
* Fix missing logo image.

* Reduce Profile->History tab height
  • Loading branch information
ruixhuang authored and mike-dydx committed Aug 20, 2024
1 parent ee7851a commit 5e371fb
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 10 deletions.
8 changes: 0 additions & 8 deletions dydx/dydxViews/dydxViews.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,6 @@
024B7B5A28B7F8F000F7C386 /* Marker */,
024B7B5428B7F89500F7C386 /* Themes */,
024B7AD628B7F78900F7C386 /* Shared */,
648327342AF5630200012B75 /* Utils */,
024B79BD28B7F53800F7C386 /* dydxViews.h */,
024B7BE328B80C2A00F7C386 /* Media.xcassets */,
024B79BE28B7F53800F7C386 /* dydxViews.docc */,
Expand Down Expand Up @@ -1422,13 +1421,6 @@
path = Components;
sourceTree = "<group>";
};
648327342AF5630200012B75 /* Utils */ = {
isa = PBXGroup;
children = (
);
path = Utils;
sourceTree = "<group>";
};
64A4DB452966205A008D8E20 /* Components */ = {
isa = PBXGroup;
children = (
Expand Down
8 changes: 7 additions & 1 deletion dydx/dydxViews/dydxViews/_v4/Auth/dydxSecurityView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,13 @@ public class dydxSecurityViewModel: PlatformViewModel {
}

private func logoImage(parentStyle: ThemeStyle, styleKey: String?) -> PlatformView {
PlatformIconViewModel(type: .asset(name: "brand", bundle: Bundle.particles.first),
let imageName: String
if currentThemeType == .light {
imageName = "brand_light"
} else {
imageName = "brand_dark"
}
return PlatformIconViewModel(type: .asset(name: imageName, bundle: Bundle.dydxView),
clip: .noClip,
size: .init(width: 100, height: 100),
templateColor: nil)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public class dydxProfileHistoryViewModel: dydxTitledCardViewModel {
.themeColor(foreground: .textTertiary)
}
.frame(maxWidth: .infinity)
.frame(minHeight: 210)
.frame(minHeight: 134)
.themeColor(background: .layer3)
.cornerRadius(12, corners: .allCorners)
.wrappedInAnyView()
Expand Down

0 comments on commit 5e371fb

Please sign in to comment.