inverted coloring for cross margin and position leverage directions

dydxprotocol · Jun 27, 2024 · 4c8bd4a · 4c8bd4a
1 parent 76167c2
commit 4c8bd4a
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/dydx/dydxPresenters/dydxPresenters/_v4/Trade/Margin/dydxAdjustMarginInputViewBuilder.swift b/dydx/dydxPresenters/dydxPresenters/_v4/Trade/Margin/dydxAdjustMarginInputViewBuilder.swift
@@ -212,7 +212,8 @@ private class dydxAdjustMarginInputViewPresenter: HostedViewPresenter<dydxAdjust
         let crossMarginUsageUpdated: AmountTextModel = .init(amount: input.summary?.crossMarginUsageUpdated, unit: .percentage)
         let crossMarginUsageChange: AmountChangeModel = .init(
             before: crossMarginUsage.amount != nil ? crossMarginUsage : nil,
-            after: crossMarginUsageUpdated.amount != nil ? crossMarginUsageUpdated : nil)
+            after: crossMarginUsageUpdated.amount != nil ? crossMarginUsageUpdated : nil,
+            increasingIsPositiveDirection: false)
         crossReceiptItems.append(
             dydxReceiptChangeItemView(
                 title: DataLocalizer.localize(path: "APP.GENERAL.CROSS_MARGIN_USAGE"),
@@ -232,7 +233,9 @@ private class dydxAdjustMarginInputViewPresenter: HostedViewPresenter<dydxAdjust
         let positionLeverageUpdated: AmountTextModel = .init(amount: input.summary?.positionLeverageUpdated, unit: .multiplier)
         let positionLeverageChange: AmountChangeModel = .init(
             before: positionLeverage.amount != nil ? positionLeverage : nil,
-            after: positionLeverageUpdated.amount != nil ? positionLeverageUpdated : nil)
+            after: positionLeverageUpdated.amount != nil ? positionLeverageUpdated : nil,
+            increasingIsPositiveDirection: false
+        )
         positionReceiptItems.append(
             dydxReceiptChangeItemView(
                 title: DataLocalizer.localize(path: "APP.TRADE.POSITION_LEVERAGE"),

diff --git a/dydx/dydxViews/dydxViews/Shared/AmountChange.swift b/dydx/dydxViews/dydxViews/Shared/AmountChange.swift
@@ -12,11 +12,22 @@ import Utilities
 
 public class AmountChangeModel: BeforeArrowAfterModel<AmountTextModel> {
 
-    public convenience init(before: AmountTextModel?, after: AmountTextModel?) {
+    public convenience init(before: AmountTextModel?, after: AmountTextModel?, increasingIsPositiveDirection: Bool = true) {
         self.init()
 
         self.before = before
         self.after = after
+
+        changeDirection = { [weak self] in
+            guard let beforeAmount = self?.before?.amount, let afterAmount = self?.after?.amount else {
+                return .orderedSame
+            }
+            if increasingIsPositiveDirection {
+                return beforeAmount.compare(afterAmount)
+            } else {
+                return afterAmount.compare(beforeAmount)
+            }
+        }
     }
 
     public required init(unit: AmountTextModel.Unit = .dollar) {