conditionally display warning for non-usdc (#184)

dydxprotocol · Aug 21, 2024 · 3d91c71 · 3d91c71
1 parent e5da267
commit 3d91c71
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/...dydxPresenters/dydxPresenters/_v4/Transfer/TransferOut/dydxTransferOutViewPresenter.swift b/...dydxPresenters/dydxPresenters/_v4/Transfer/TransferOut/dydxTransferOutViewPresenter.swift
@@ -159,6 +159,7 @@ class dydxTransferOutViewPresenter: HostedViewPresenter<dydxTransferOutViewModel
 
         viewModel?.addressInput?.value = transferInput.address
 
+        viewModel?.memoBox?.shouldDisplayWarningWhenEmpty = transferInput.token != dydxTokenConstants.usdcTokenKey
         viewModel?.memoBox?.value = transferInput.memo
     }
 

diff --git a/dydx/dydxViews/dydxViews/_v4/Transfer/Components/MemoBox.swift b/dydx/dydxViews/dydxViews/_v4/Transfer/Components/MemoBox.swift
@@ -12,6 +12,7 @@ import dydxFormatter
 
 public class MemoBoxModel: PlatformTextInputViewModel {
     @Published public var pasteAction: (() -> Void)?
+    @Published public var shouldDisplayWarningWhenEmpty: Bool = false
 
     public init(onEdited: ((String?) -> Void)?) {
         super.init(label: DataLocalizer.localize(path: "APP.GENERAL.MEMO"),
@@ -20,7 +21,7 @@ public class MemoBoxModel: PlatformTextInputViewModel {
     }
 
     private var memoWarning: InlineAlertViewModel? {
-        guard value?.isEmpty != false else { return nil }
+        guard value?.isEmpty != false && shouldDisplayWarningWhenEmpty else { return nil }
         return InlineAlertViewModel(.init(title: nil,
                                    body: DataLocalizer.localize(path: "ERRORS.TRANSFER_MODAL.TRANSFER_WITHOUT_MEMO"),
                                    level: .warning))
-Original file line number
+Diff line change
@@ Expand Up @@
             viewModel?.addressInput?.value = transferInput.address
+            viewModel?.memoBox?.shouldDisplayWarningWhenEmpty = transferInput.token != dydxTokenConstants.usdcTokenKey
             viewModel?.memoBox?.value = transferInput.memo
         }
@@ Expand Down @@