Skip to content

Commit

Permalink
remove view(...) functions
Browse files Browse the repository at this point in the history
  • Loading branch information
mike-dydx committed May 17, 2024
1 parent d722c9b commit 1541e31
Show file tree
Hide file tree
Showing 47 changed files with 374 additions and 2,582 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ public class AppsFlyerTracking: TransformerTracker {
}
}

override open func view(_ path: String?, action: String?, data: [String: Any]?, from: String?, time: Date?, revenue: NSNumber?, contextViewController: UIViewController?) {
// Only track the ones required by growth
}

override public func log(event: String, data: [String: Any]?, revenue: NSNumber?) {
if !excluded {
var data = data
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public class FirebaseTracking: TransformerTracker {

override public init() {
super.init()
FirebaseConfiguration.shared.setLoggerLevel(.min)
FirebaseConfiguration.shared.setLoggerLevel(.max)
Analytics.setUserProperty(String(format: "%.4f", UIDevice.current.systemVersionAsFloat), forName: "os_version")
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,6 @@ open class TransformerTracker: NSObject & TrackingProtocol {
}
}

open func view(_ path: String?, action: String?, data: [String: Any]?, from: String?, time: Date?, revenue: NSNumber?, contextViewController: UIViewController?) {
if !excluded {
if let path = transform(path: path)?.trim() {
if let action = action {
log(event: "\(path)_\(action)", data: data, revenue: revenue)
} else {
log(event: path, data: data, revenue: revenue)
}
}
}
}

open func leave(_ path: String?) {
}

Expand Down
12 changes: 0 additions & 12 deletions Utilities/Utilities/_Tracker/_Shared/DebugTracking.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,6 @@ public class DebugTracking: NSObject & TrackingProtocol {
public var userInfo: [String: String?]?

public var excluded: Bool = false

public func view(_ path: String?, action: String?, data: [String: Any]?, from: String?, time: Date?, revenue: NSNumber?, contextViewController: UIViewController?) {
if let path = path {
let action = action ?? ""
let from = from ?? ""
if excluded {
Console.shared.log("Debug Tracking: View Excluded Path:\(path) Action:\(action) From:\(from)", data ?? "")
} else {
Console.shared.log("Debug Tracking: View Path:\(path) Action:\(action) From:\(from)", data ?? "")
}
}
}

public func leave(_ path: String?) {
if let path = path {
Expand Down
16 changes: 0 additions & 16 deletions Utilities/Utilities/_Tracker/_Shared/Tracking.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,27 +11,11 @@ import Foundation
public protocol TrackingProtocol: NSObjectProtocol {
var userInfo: [String: String?]? { get set }
var excluded: Bool { get set }
// func view(_ path: String?, action: String?, data: [String: Any]?, from: String?, time: Date?, revenue: NSNumber?, contextViewController: UIViewController?)
func leave(_ path: String?)
func log(event: String, data: [String: Any]?, revenue: NSNumber?)
}

public extension TrackingProtocol {
// func view(_ path: String?, data: [String: Any]?, from: String?, time: Date?, revenue: NSNumber?, contextViewController: UIViewController?) {
// view(path, action: nil, data: data, from: from, time: time, revenue: revenue, contextViewController: contextViewController)
// }
// func view(_ path: String?, data: [String: Any]?, from: String?, time: Date?, revenue: NSNumber?) {
// view(path, action: nil, data: data, from: from, time: time, revenue: revenue, contextViewController: nil)
// }
// func view(_ path: String?, data: [String: Any]?, from: String?, time: Date?) {
// view(path, action: nil, data: data, from: from, time: time, revenue: nil, contextViewController: nil)
// }
// func view(_ path: String?, data: [String: Any]?, from: String?, contextViewController: UIViewController?) {
// view(path, action: nil, data: data, from: from, time: nil, revenue: nil, contextViewController: nil)
// }
// func view(_ path: String?, data: [String: Any]?) {
// view(path, action: nil, data: data, from: nil, time: nil, revenue: nil, contextViewController: nil)
// }
func log(event: String, data: [String: Any]?) {
log(event: event, data: data, revenue: nil)
}
Expand Down
41 changes: 0 additions & 41 deletions dydx/Pods/Local Podspecs/MagicSDK.podspec.json

This file was deleted.

177 changes: 0 additions & 177 deletions dydx/Pods/MagicSDK/LICENSE

This file was deleted.

41 changes: 0 additions & 41 deletions dydx/Pods/MagicSDK/README.md

This file was deleted.

Loading

0 comments on commit 1541e31

Please sign in to comment.