address PR comments

dydxprotocol · Jul 24, 2024 · 04aa600 · 04aa600
1 parent dc5d5dd
commit 04aa600
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/dydx/dydxFormatter/dydxFormatter/dydxNumberInputFormatter.swift b/dydx/dydxFormatter/dydxFormatter/dydxNumberInputFormatter.swift
@@ -12,7 +12,7 @@ import Foundation
 public class dydxNumberInputFormatter: NumberFormatter {
 
     /// if greater than 0, numbers will be rounded to nearest 10, 100, 1000, etc. If less than 0 numbers will be rounded to nearest 0.1, 0.01, .001
-    var fractionDigits: Int {
+    public var fractionDigits: Int {
         get {
             maximumFractionDigits
         }

diff --git a/dydx/dydxViews/dydxViews/Shared/dydxComponents/dydxSliderInputView.swift b/dydx/dydxViews/dydxViews/Shared/dydxComponents/dydxSliderInputView.swift
@@ -17,17 +17,21 @@ public class dydxSliderInputViewModel: PlatformViewModel {
     @Published public var minValue: Double = 0
     @Published public var maxValue: Double = 0
     /// number of decimals after the decimal place to display
-    @Published public var precision: Int = 0
+    @Published public var precision: Int = 0 {
+        didSet {
+            numberFormatter.fractionDigits = precision
+        }
+    }
     @Published public private(set) var valueAsString: String = ""
     @Published public var value: Double? {
         didSet {
             valueAsString = value.map { numberFormatter.string(from: $0 as NSNumber) ?? "" } ?? ""
         }
     }
 
-    var numberFormatter: dydxNumberInputFormatter {
+    private lazy var numberFormatter: dydxNumberInputFormatter = {
         dydxNumberInputFormatter(fractionDigits: precision)
-    }
+    }()
 
     init(title: String?, accessoryTitle: String? = nil, precision: Int) {
         self.title = title

diff --git a/dydx/dydxViews/dydxViews/Shared/dydxComponents/dydxTitledNumberField.swift b/dydx/dydxViews/dydxViews/Shared/dydxComponents/dydxTitledNumberField.swift
@@ -83,9 +83,14 @@ private struct NumberTextField: View {
     let minValue: Double
     let maxValue: Double
     let precision: Int
-
-    private var numberFormatter: dydxNumberInputFormatter {
-        dydxNumberInputFormatter(fractionDigits: precision)
+    let numberFormatter: dydxNumberInputFormatter
+
+    init(actualValue: Binding<Double?>, minValue: Double, maxValue: Double, precision: Int) {
+        self._actualValue = actualValue
+        self.minValue = minValue
+        self.maxValue = maxValue
+        self.precision = precision
+        self.numberFormatter = dydxNumberInputFormatter(fractionDigits: precision)
     }
 
     private var keyboardType: UIKeyboardType {