Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing threading issues #79

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Fixing threading issues #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8907d18
Fixing threading issues.
ruixhuang Apr 23, 2024
b01bb62
Clean up
ruixhuang Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions ...rc/main/java/exchange/dydx/dydxstatemanager/protocolImplementations/AbacusThreadingImp.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,32 @@ class AbacusThreadingImp @Inject constructor(
@CoroutineDispatchers.IO private val ioDispatcher: CoroutineDispatcher,
@CoroutineDispatchers.Default private val defaultDispatcher: CoroutineDispatcher,
) : ThreadingProtocol {

private val mainScope = appScope

// Abacus runs lots of computations, but needs to be run without parallelism
private val abacusScope = appScope + defaultDispatcher.limitedParallelism(1)
private val networkScope = appScope + ioDispatcher

override fun async(type: ThreadingType, block: () -> Unit) {
when (type) {
main -> appScope.launch { block() }
// Abacus runs lots of computations, but needs to be run without parallelism
abacus -> appScope.launch(defaultDispatcher.limitedParallelism(1)) { block() }
network -> appScope.launch(ioDispatcher) { block() }
main ->
mainScope
.launch {
block()
}

abacus ->
abacusScope
.launch {
block()
}

network ->
networkScope
.launch {
block()
}
}
}
}
Loading