Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOB-277: Tab group scrolling improvement #13

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

ruixhuang
Copy link
Contributor

We have logic to auto-scroll to the selected tab item, but it should happen only when the selection changes. This PR adds this condition to prevent undesirable scrolling behavior.

untitled.webm

@ruixhuang ruixhuang requested review from johnqh and mike-dydx March 6, 2024 15:56
Copy link

linear bot commented Mar 6, 2024

MOB-277 [Feb 29 Testing Issue]: hard to scroll on transfer options

actual behavior:
scrollable items bounce

expected behavior:

bounce should not happen until end of list is reached

reproduction steps:

screenshots/recordings:

Screenrecorder-2024-02-29-13-08-12-900.mp4

@johnqh johnqh merged commit fa9e3b2 into develop Mar 7, 2024
3 checks passed
@johnqh johnqh deleted the feature/tab_group branch March 7, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants