Safeguard for orderbook duplicated keys

dydxprotocol · Nov 22, 2024 · 6e0e2ba · 6e0e2ba
1 parent 574347d
commit 6e0e2ba
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/.../exchange/dydx/trading/feature/receipt/components/ordercount/DydxReceiptOrderCountView.kt b/.../exchange/dydx/trading/feature/receipt/components/ordercount/DydxReceiptOrderCountView.kt
@@ -75,7 +75,7 @@ object DydxReceiptOrderCountView : DydxComponent {
             Spacer(modifier = Modifier.weight(0.1f))
 
             PlatformAmountChange(
-                 before = state.before?.let {
+                before = state.before?.let {
                     {
                         Text(
                             text = state.formatter.localFormatted(it.toDouble(), 0) ?: "",

diff --git a/...in/java/exchange/dydx/trading/feature/trade/orderbook/components/DydxOrderbookSideView.kt b/...in/java/exchange/dydx/trading/feature/trade/orderbook/components/DydxOrderbookSideView.kt
@@ -221,9 +221,9 @@ object DydxOrderbookSideView {
                     }
                 } else {
                     item {
-                        Spacer(modifier = Modifier.height(actualLineHeight))
+                        Spacer(modifier = Modifier.height(actualLineHeight).animateItemPlacement())
                         if (i < numLinesToDisplay - 1) {
-                            Spacer(modifier = Modifier.height(state.displayStyle.spacing))
+                            Spacer(modifier = Modifier.height(state.displayStyle.spacing).animateItemPlacement())
                         }
                     }
                 }

diff --git a/...va/exchange/dydx/trading/feature/trade/orderbook/components/DydxOrderbookSideViewModel.kt b/...va/exchange/dydx/trading/feature/trade/orderbook/components/DydxOrderbookSideViewModel.kt
@@ -140,6 +140,9 @@ private fun createViewState(
     val items = lines.take(12)
     val output: MutableList<DydxOrderbookSideView.DydxOrderbookLine> = mutableListOf()
     items.forEach { line ->
+        if (output.find { it.price == line.price } != null) {
+            return@forEach
+        }
         val textColor: ThemeColor.SemanticColor
         if (colorMap.containsKey(line.price)) {
             val entry = colorMap[line.price]!!