Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better cancel reason strings #248

Merged
merged 3 commits into from
Jan 31, 2024
Merged

better cancel reason strings #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96034c0
better cancel reason strings
johnqh Jan 25, 2024
0379f4b
Merge branch 'main' into feature/TRCL-3524-cancel-reasons
johnqh Jan 31, 2024
f2c5896
Up version
johnqh Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions config/localization/en/app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,18 +986,21 @@
"ORDER_FILLED": "Filled",
"ORDER_LINES": "Order Lines",
"ORDER_LINES_TOOLTIP": "Display or hide order lines",
"ORDER_REMOVAL_REASON_EXPIRED": "Expired",
"ORDER_REMOVAL_REASON_FOK_ORDER_COULD_NOT_BE_FULLY_FULLED": "Fill or Kill order could not be fully filled",
"ORDER_REMOVAL_REASON_IMMEDIATE_OR_CANCEL_WOULD_REST_ON_BOOK": "Immediate or Cancel order would rest on book",
"ORDER_REMOVAL_REASON_INDEXER_EXPIRED": "Internal error",
"ORDER_REMOVAL_REASON_INTERNAL_ERROR": "Internal error",
"ORDER_REMOVAL_REASON_POST_ONLY_WOULD_CROSS_MAKER_ORDER": "Post Only would match maker order",
"ORDER_REMOVAL_REASON_REDUCED_ONLY_RESIZE": "Reduced only resize",
"ORDER_REMOVAL_REASON_REPLACED": "Replaced",
"ORDER_REMOVAL_REASON_SELF_TRADE_ERROR": "Self trade error",
"ORDER_REMOVAL_REASON_UNDERCOLLATERALIZED": "Undercollateralized",
"ORDER_REMOVAL_REASON_UNSPECIFIED": "Unspecified",
"ORDER_REMOVAL_REASON_USER_CANCELED": "User canceled",
"ORDER_REMOVAL_REASON_EQUITY_TIER": "The subaccount does not satisfy the equity tier requirements.",
"ORDER_REMOVAL_REASON_EXPIRED": "The order has expired.",
"ORDER_REMOVAL_REASON_FOK_ORDER_COULD_NOT_BE_FULLY_FULLED": "The Fill-Or-Kill order could not be fully filled.",
"ORDER_REMOVAL_REASON_FINAL_SETTLEMENT": "The order's ClobPair has entered final settlement.",
"ORDER_REMOVAL_REASON_FULLY_FILLED": "The order has been fully-filled.",
"ORDER_REMOVAL_REASON_IMMEDIATE_OR_CANCEL_WOULD_REST_ON_BOOK": "The Immediate-Or-Cancel order has not been fully filled.",
"ORDER_REMOVAL_REASON_INDEXER_EXPIRED": "The order has expired.",
"ORDER_REMOVAL_REASON_INTERNAL_ERROR": "The order caused an internal error during order placement.",
"ORDER_REMOVAL_REASON_POST_ONLY_WOULD_CROSS_MAKER_ORDER": "The order would have matched against maker orders on the orderbook despite being a post-only order.",
"ORDER_REMOVAL_REASON_REDUCED_ONLY_RESIZE": "The reduce-only order has either closed the subaccount's position, or the existing position has closed or flipped.",
"ORDER_REMOVAL_REASON_REPLACED": "The order has been replaced.",
"ORDER_REMOVAL_REASON_SELF_TRADE_ERROR": "The order would have matched against another order placed by the same subaccount.",
"ORDER_REMOVAL_REASON_UNDERCOLLATERALIZED": "The order was removed due to being undercollateralized.",
"ORDER_REMOVAL_REASON_UNSPECIFIED": "Unspecified error.",
"ORDER_REMOVAL_REASON_USER_CANCELED": "The order was canceled by a user.",
"ORDER_TYPE": "Order type",
"ORDERBOOK": "Order book",
"ORDERBOOK_ASK_PRICE": "Ask Price",
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dydxprotocol/v4-localization",
"version": "1.1.19",
"version": "1.1.20",
"description": "v4 localization",
"main": "index.ts",
"scripts": {
Expand Down
3 changes: 3 additions & 0 deletions scripts/generated/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,8 +1243,11 @@ export const APP_STRING_KEYS = {
ORDER_FILLED: 'APP.TRADE.ORDER_FILLED',
ORDER_LINES: 'APP.TRADE.ORDER_LINES',
ORDER_LINES_TOOLTIP: 'APP.TRADE.ORDER_LINES_TOOLTIP',
ORDER_REMOVAL_REASON_EQUITY_TIER: 'APP.TRADE.ORDER_REMOVAL_REASON_EQUITY_TIER',
ORDER_REMOVAL_REASON_EXPIRED: 'APP.TRADE.ORDER_REMOVAL_REASON_EXPIRED',
ORDER_REMOVAL_REASON_FINAL_SETTLEMENT: 'APP.TRADE.ORDER_REMOVAL_REASON_FINAL_SETTLEMENT',
ORDER_REMOVAL_REASON_FOK_ORDER_COULD_NOT_BE_FULLY_FULLED: 'APP.TRADE.ORDER_REMOVAL_REASON_FOK_ORDER_COULD_NOT_BE_FULLY_FULLED',
ORDER_REMOVAL_REASON_FULLY_FILLED: 'APP.TRADE.ORDER_REMOVAL_REASON_FULLY_FILLED',
ORDER_REMOVAL_REASON_IMMEDIATE_OR_CANCEL_WOULD_REST_ON_BOOK: 'APP.TRADE.ORDER_REMOVAL_REASON_IMMEDIATE_OR_CANCEL_WOULD_REST_ON_BOOK',
ORDER_REMOVAL_REASON_INDEXER_EXPIRED: 'APP.TRADE.ORDER_REMOVAL_REASON_INDEXER_EXPIRED',
ORDER_REMOVAL_REASON_INTERNAL_ERROR: 'APP.TRADE.ORDER_REMOVAL_REASON_INTERNAL_ERROR',
Expand Down
Loading