Trading Rewards Copy #198
Merged
Trading Rewards Copy #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aforaleka
reviewed
Dec 8, 2023
config/localization/en/app.json
Outdated
Comment on lines
1417
to
1344
| "TRADING_REWARDS" : { | ||
| "EVENT": "Event", | ||
| "FOR_TRADING": "For trading {PERIOD}", | ||
| "TRADING_REWARD": "Trading Reward" | ||
| }, |
There was a problem hiding this comment.
aforaleka
approved these changes
Dec 22, 2023
aforaleka
reviewed
Dec 22, 2023
config/localization/en/app.json
Outdated
| @@ -1394,6 +1401,8 @@ | |||
| "POSTAL_CODE": "Postal Code", | |||
| "PRINT_NAME": "Print Name", | |||
| "REWARDS_BY_EPOCH": "Rewards by Epoch", | |||
| "REWARDS_LAST_7_DAYS": "Rewards last 7 days", | |||
There was a problem hiding this comment.
don't think we need this anymore -- should be This week or This week rewards
There was a problem hiding this comment.
addressed in bb53067
jaredvu
reviewed
Dec 22, 2023
config/localization/en/app.json
Outdated
| @@ -128,6 +131,7 @@ | |||
| "GO_TO_MARKET": "Go to market", | |||
| "GOVERNANCE": "Governance", | |||
| "HEDGIES": "Hedgies", | |||
| "HELP": "Help", | |||
There was a problem hiding this comment.
addressed in bb53067
mike-dydx
force-pushed
the
mike/trcl-3314-trading-rewards-profile-card
branch
from
6bdb30f to
8b0bb87
Compare
aforaleka
suggested changes
Jan 3, 2024
config/localization/en/app.json
Outdated
| @@ -676,7 +683,8 @@ | |||
| "LEGAL": { | |||
| "ACADEMY_LINK_DESCRIPTION": "To access the dYdX Academy, you will leave the dYdX Trading Inc. website and join a website made available by dYdX Foundation, which is independent from and unaffiliated with dYdX Trading Inc. dYdX Trading Inc. is not responsible for any action taken or content on the third-party website.", | |||
| "LEGAL": "Legal", | |||
| "GOVERNANCE_LINK_DESCRIPTION": "To participate in governance, you will leave the dYdX Trading Inc. website and join a website made available by dYdX Foundation, which is independent from and unaffiliated with dYdX Trading Inc. dYdX Trading Inc. is not responsible for any action taken or content on the third-party website.", | |||
| "GOVERNANCE_LINK_DESCRIPTION": "To participate in governance, you need to export your secret phrase to Keplr Wallet.", | |||
There was a problem hiding this comment.
ah it looks like now it's a duplicate of the one inside TRADING_REWARDS? should we just keep one?
also where is this supposed to show up? i think these should be the most updated according to feedback by antonio:
config/localization/en/app.json
Outdated
| @@ -1314,7 +1322,31 @@ | |||
| "TRADE_TO_WIN": "Trade to win", | |||
| "TRADERS_JOINED": "Traders Joined", | |||
| "USERS_REFERRED": "Users Referred", | |||
| "YOU_CAN_WIN_THESE": "You can win these in our {LEAGUES_LINK}" | |||
| "YOU_CAN_WIN_THESE": "You can win these in our {LEAGUES_LINK}", | |||
| "REWARD_HISTORY_TOOLTIP": "Time is displayed in Coordinated Universal Time (UTC)" | |||
There was a problem hiding this comment.
might want to include this in the tooltip strings instead
config/localization/en/app.json
Outdated
| "GOVERNANCE": "Governance", | ||
| "GOVERNANCE_LINK_DESCRIPTION": "To participate in governance, you need to export your secret phrase to Keplr Wallet.", | ||
| "LAUNCH_INCENTIVES":"Launch Incentives", | ||
| "LAUNCH_INCENTIVES_DESCRIPTION":"Each season, you can earn rewards for trading on dYdX Chain. Trade to earn your rightful spot on the leaderboard.", |
There was a problem hiding this comment.
this is the most updated according to legal
config/localization/en/app.json
Outdated
Comment on lines
1344
to
1349
| "FAQ_WHO_IS_ELIGIBLE_QUESTION":"Who is eligible for trading rewards?", | ||
| "FAQ_WHO_IS_ELIGIBLE_ANSWER":"All traders are eligible for trading rewards.", | ||
| "FAQ_HOW_DO_TRADING_REWARDS_WORK_QUESTION":"How do trading rewards work?", | ||
| "FAQ_HOW_DO_TRADING_REWARDS_WORK_ANSWER":"Immediately after each fill, trading rewards are sent directly to the trader’s dYdX Chain address, based on the amount of fees paid by the trader.", | ||
| "FAQ_HOW_DO_I_CLAIM_MY_REWARDS_QUESTION":"How do I claim my rewards?", | ||
| "FAQ_HOW_DO_I_CLAIM_MY_REWARDS_ANSWER":"Each block, trading rewards are automatically sent directly to the trader’s dYdX Chain address." |
mike-dydx
force-pushed
the
mike/trcl-3314-trading-rewards-profile-card
branch
from
8a9e79b to
4f69b22
Compare
mike-dydx
force-pushed
the
mike/trcl-3314-trading-rewards-profile-card
branch
from
4f69b22 to
2a1b6cb
Compare
mike-dydx
force-pushed
the
mike/trcl-3314-trading-rewards-profile-card
branch
from
2a1b6cb to
72884eb
Compare
mike-dydx
commented
Jan 4, 2024
| @@ -198,6 +198,9 @@ | |||
| "UNREALIZED_PNL": { | |||
| "TITLE": "Unrealized Profit / Loss", | |||
| "BODY": "Total profit / loss if you were to fully close the remainder of your current position at the current oracle price. Resets if you close your position or change position sides (long to short, or vice versa)." | |||
| }, | |||
| "REWARD_HISTORY": { | |||
| "BODY": "Time is displayed in Coordinated Universal Time (UTC)" | |||
There was a problem hiding this comment.
note, the tooltip does not have a title per design
aforaleka
approved these changes
Jan 4, 2024
mike-dydx
force-pushed
the
mike/trcl-3314-trading-rewards-profile-card
branch
from
72884eb to
8c8b844
Compare
mike-dydx
force-pushed
the
mike/trcl-3314-trading-rewards-profile-card
branch
from
8c8b844 to
939429b
Compare
mike-dydx
force-pushed
the
mike/trcl-3314-trading-rewards-profile-card
branch
from
d8ba3d8 to
ca4dcd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRCL-3446 : add trading rewards localization strings
Figma