update notifications string key naming #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ruixhuang
reviewed
Nov 28, 2023
There was a problem hiding this comment.
This is going to break existing deployment since Abacus uses old strings:
How about keeping the existing json, and adding the new ones without the "NOTIFICATIONS" root? This way, old deployment can still work, and we can delete the old json content after updating Abacus.
|
@ruixhuang The current notification stringKeys that the script generates is |
aforaleka
force-pushed
the
remove-notifications-prefix-from-string-key
branch
from
7aa76e3 to
5329f17
Compare
ruixhuang
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the extra
NOTIFICATIONS.prefix by updating the codegen script, matching tooltips