Don't increment messageId for custom ping messages (backport #2493) (#…

…2498) Co-authored-by: dydxwill <[email protected]>
dydxprotocol · Oct 16, 2024 · 21cc9b9 · 21cc9b9
1 parent 212a015
commit 21cc9b9
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/indexer/services/socks/src/websocket/index.ts b/indexer/services/socks/src/websocket/index.ts
@@ -243,8 +243,6 @@ export class Index {
       return;
     }
 
-    this.connections[connectionId].messageId += 1;
-
     const messageStr = message.toString();
 
     let parsed: IncomingMessage;
@@ -282,6 +280,8 @@ export class Index {
           messageContents: safeJsonStringify(message),
         });
 
+        this.connections[connectionId].messageId += 1;
+
         // Do not wait for this.
         this.subscriptions.subscribe(
           this.connections[connectionId].ws,
@@ -311,6 +311,8 @@ export class Index {
           unsubscribeMessage.id,
         );
 
+        this.connections[connectionId].messageId += 1;
+
         sendMessage(
           this.connections[connectionId].ws,
           connectionId,