Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Polygon route #764

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix Polygon route #764

merged 2 commits into from
Dec 3, 2024

Conversation

ruixhuang
Copy link
Contributor

The Polygon route in cctp.json has the same value as what Skip returns but different cases. So the comparison needs to be case-insensitive.

@ruixhuang ruixhuang marked this pull request as ready for review December 3, 2024 20:07
tyleroooo
tyleroooo previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@tyleroooo tyleroooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weren't there comparisons in the other pr that didn't do the lowercase() checks too?

@ruixhuang
Copy link
Contributor Author

weren't there comparisons in the other pr that didn't do the lowercase() checks too?

Yeah.. added one more... Please restamp

@ruixhuang ruixhuang merged commit f7208a2 into main Dec 3, 2024
3 checks passed
@ruixhuang ruixhuang deleted the feature/filter_cctp_1 branch December 3, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyleroooo tyleroooo tyleroooo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruixhuang @tyleroooo