New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ignore orders that reduce position in equity check #760

Merged

jaredvu merged 2 commits into main from jared/bug2-7-cant-close-an-isolated-position-by-making-an-opposite-type

Nov 25, 2024

Contributor

jaredvu commented Nov 25, 2024 •

edited

Loading

This error would be triggered whenever postOrderFreeCollateral is larger than your current free collateral.

When you are reducing your position the orderEquity will be negative.


          Ignore orders that reduce position in equity check

fd3aad0

linear bot commented Nov 25, 2024

BUG2-7 Can't close an isolated position by making an opposite-type same-size limit/market order

jaredvu changed the title ~~Ignore orders that reduce position in equity check~~ fix: Ignore orders that reduce position in equity check


          spotlessApply

d35bc91

tyleroooo approved these changes

View reviewed changes

jaredvu merged commit 9e45b54 into main

3 checks passed

jaredvu deleted the jared/bug2-7-cant-close-an-isolated-position-by-making-an-opposite-type branch

November 25, 2024 23:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet