Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ticker to the static typed model for Fill object. #747

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

ruixhuang
Copy link
Contributor

Websocket Fill message uses "ticker" instead of "market", and it's not part of the backend Swagger for the codegen to generate the correct model.

Unfortunately we have the manually create the Fill model to include "ticker" as Kotlin data class can't be subclassed.

Tested with the Android app

@ruixhuang ruixhuang marked this pull request as ready for review November 13, 2024 01:06
@ruixhuang ruixhuang merged commit 0e5cba8 into main Nov 13, 2024
3 checks passed
@ruixhuang ruixhuang deleted the feature/fills_fix branch November 13, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants