Static typing: Historical funding and fixing issues with isolated market orders #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruixhuang
commented
Nov 5, 2024
| @@ -68,7 +68,7 @@ internal class ReceiptCalculator { | |||
| listOf( | |||
| ReceiptLine.Equity, | |||
| ReceiptLine.MarginUsage, | |||
| ReceiptLine.Fee, | |||
| ReceiptLine.TransferFee, | |||
There was a problem hiding this comment.
For mobile only. FE web doesn't use this.
ruixhuang
commented
Nov 5, 2024
| @@ -193,11 +193,12 @@ internal class SubaccountTransformerV2( | |||
| hasTransfer: Boolean = false, | |||
| ) { | |||
| val deltaMarketId = delta?.marketId | |||
| val positions = subaccount.openPositions | |||
| val positions = subaccount.openPositions ?: mapOf() | |||
There was a problem hiding this comment.
Fixing issue when create a new subaccount for isolated margin.
ruixhuang
commented
Nov 5, 2024
| usdcSize = usdcSize, | ||
| fee = null, | ||
| fee = transfer.fee, |
There was a problem hiding this comment.
For mobile only. FE web doesn't use this.
ruixhuang
commented
Nov 5, 2024
| @@ -27,7 +27,8 @@ enum class ReceiptLine(val rawValue: String) { | |||
| CrossMarginUsage("CROSS_MARGIN_USAGE"), | |||
| PositionMargin("POSITION_MARGIN"), | |||
| PositionLeverage("POSITION_LEVERAGE"), | |||
| LiquidationPrice("LIQUIDATION_PRICE"); | |||
| LiquidationPrice("LIQUIDATION_PRICE"), | |||
| TransferFee("TRANSFER_FEE"); | |||
There was a problem hiding this comment.
For mobile only. FE web doesn't use this.
ruixhuang
commented
Nov 5, 2024
| val modified = input?.mutable() ?: iMapOf<String, Any>().mutable() | ||
| modified.safeSet("transfer.fee", gas) | ||
| update(StateChanges(iListOf(Changes.input)), oldState) | ||
| if (stateMachine.staticTyping) { |
There was a problem hiding this comment.
Adding processing for transfer gas
tyleroooo
previously approved these changes
Nov 5, 2024
tyleroooo
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Android and iOS.