Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the unnecessary network reconnect #732

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Reduce the unnecessary network reconnect #732

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08d3123
Reduce the unnecessary network reconnects
ruixhuang Oct 24, 2024
83ac810
Merge branch 'main' into feature/ios_list_fix
ruixhuang Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/commonMain/kotlin/exchange.dydx.abacus/state/v2/manager/AsyncAbacusStateManagerV2.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ class AsyncAbacusStateManagerV2(

private var environments: IList<V4Environment> = iListOf()
set(value) {
field = value
ioImplementations.threading?.async(ThreadingType.abacus) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for threading switch 'cos it's called from the same thread.

if (field != value) {
field = value
_environment = findEnvironment(environmentId)
ioImplementations.threading?.async(ThreadingType.main) {
stateNotification?.environmentsChanged()
Expand All @@ -117,8 +117,11 @@ class AsyncAbacusStateManagerV2(
private var _environment: V4Environment? = null
set(value) {
if (field !== value) {
val shouldReconnect = field?.id != value?.id
field = value
reconnect()
if (shouldReconnect) {
reconnect()
}
}
}

Expand Down