Set route gasPrice and gasLimit to null #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogurtandjam
approved these changes
Oct 22, 2024
| @@ -1,6 +1,6 @@ | |||
| Pod::Spec.new do |spec| | |||
| spec.name = 'v4_abacus' | |||
| spec.version = '1.13.6' | |||
| spec.version = '1.13.7' | |||
There was a problem hiding this comment.
since we're removing properties from state this is technically a breaking change, right?
There was a problem hiding this comment.
No, it doesn't change the state exposed to the client. We only removed it from the internal state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to get gas values for the transfer route with Squid and pass them along to the wallet. But with Skip we no longer get them. It's better to set them to null for the wallet to figure out the values.