Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a little tolerance for floating point precision #717

Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix: add a little tolerance for floating point precision #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5da339d
epsilon
tyleroooo Oct 17, 2024
fec078f
down
tyleroooo Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ allprojects {
}

group = "exchange.dydx.abacus"
version = "1.13.0"
version = "1.13.1"

repositories {
google()
Expand Down
7 changes: 4 additions & 3 deletions src/commonMain/kotlin/exchange.dydx.abacus/functional/vault/VaultDepositWithdrawForm.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ object VaultDepositWithdrawFormValidator {
private const val SLIPPAGE_PERCENT_WARN = 0.01
private const val SLIPPAGE_PERCENT_ACK = 0.04
private const val SLIPPAGE_TOLERANCE = 0.01
private const val EPSILON_FOR_ERRORS = 0.0001

private const val MIN_DEPOSIT_FE_THRESHOLD = 20.0

Expand Down Expand Up @@ -370,15 +371,15 @@ object VaultDepositWithdrawFormValidator {

when (formData.action) {
VaultFormAction.DEPOSIT -> {
if (postOpFreeCollateral != null && postOpFreeCollateral < 0) {
if (postOpFreeCollateral != null && postOpFreeCollateral < -EPSILON_FOR_ERRORS) {
errors.add(vaultFormValidationErrors.depositTooHigh())
}
if (amount > 0 && amount < MIN_DEPOSIT_FE_THRESHOLD) {
errors.add(vaultFormValidationErrors.depositTooLow())
}
}
VaultFormAction.WITHDRAW -> {
if (postOpVaultBalance != null && postOpVaultBalance < 0) {
if (postOpVaultBalance < -EPSILON_FOR_ERRORS) {
errors.add(vaultFormValidationErrors.withdrawTooHigh())
}
if (amount > 0 && amount < MIN_DEPOSIT_FE_THRESHOLD) {
Expand All @@ -391,7 +392,7 @@ object VaultDepositWithdrawFormValidator {
errors.add(vaultFormValidationErrors.withdrawTooLow())
}
}
if (postOpVaultBalance != null && postOpVaultBalance >= 0 && amount > 0 &&
if (postOpVaultBalance >= -EPSILON_FOR_ERRORS && amount > 0 &&
vaultAccount?.withdrawableUsdc != null && amount > vaultAccount.withdrawableUsdc
) {
errors.add(vaultFormValidationErrors.withdrawingLockedBalance())
Expand Down
2 changes: 1 addition & 1 deletion v4_abacus.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |spec|
spec.name = 'v4_abacus'
spec.version = '1.13.0'
spec.version = '1.13.1'
spec.homepage = 'https://github.com/dydxprotocol/v4-abacus'
spec.source = { :http=> ''}
spec.authors = ''
Expand Down