fix: revert default validator url logic #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogurtandjam
force-pushed
the
jerms/revert-default-validator-url
branch
from
e35eda4 to
61fbff8
Compare
ruixhuang
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert core logic of #661
PR 661 optimistically assigned a node and then attempted to connect to the optimalnode in the background. This was intended to reduce latency to find an optimal validator.
However, defaulting to the first node occasionally results in a connection failure. v4-web doesn't have the ability to properly reconnect once a connection attempt has failed which has cause a significant degradation in user experience in a significant number of cases