Add api state params to tracking #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aforaleka
force-pushed
the
add-more-api-state-params-to-tracking
branch
from
aa83fb4 to
38b3cb7
Compare
ruixhuang
reviewed
Sep 24, 2024
| @@ -555,4 +556,16 @@ class NetworkHelper( | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| internal fun apiStateParams(): IMap<String, Any>? { | |||
There was a problem hiding this comment.
Nit: return type can be non-optional, e.g,. IMap<String, Any>
There was a problem hiding this comment.
mm yea our ParsingHelper merge functions take in that specific type... not sure what's the best way to cast/not cast t_t
There was a problem hiding this comment.
will send it for nowwww!
ruixhuang
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
research found out that these fields are missing
think we didn't add them back when refactoring to the different supervisors?