fix: fix isolated pnl transfer calc #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruixhuang
reviewed
Sep 19, 2024
| OrderSide.Buy -> entryPrice - (oraclePrice ?: entryPrice) | ||
| OrderSide.Sell -> (oraclePrice ?: entryPrice) - entryPrice | ||
| } | ||
| val pnlImpact = (diff * balance * tradeLeverage) / (entryPrice + diff * tradeLeverage) |
There was a problem hiding this comment.
Do we need to check for dividing by zero?
There was a problem hiding this comment.
haha i alwayyyys forget this huh
ruixhuang
previously approved these changes
Sep 19, 2024
ruixhuang
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed a bug when testing this feature - isolated margin percent inputs looked wrong esp when the amount was high - realized it was cuz the collateral transfer calculation was wrong - we need to include the isolatedPnlImpact in the balance used
(for some reason when I build locally now it keeps telling the testnet chain is halted? I tried with building a local abacus with no change but an extra space and it still said halted so assuming this is not related)
fix.mov