TRCL-3695 Add configs for notification provider types #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dydx
reviewed
Sep 17, 2024
| jsonEncoder, | ||
| ), | ||
| val notifications: List<NotificationProviderType> = listOf( | ||
| NotificationProviderType.BlackReward, |
ruixhuang
commented
Sep 17, 2024
| @@ -251,8 +251,7 @@ class DynamicLocalizer( | |||
| } | |||
| } | |||
| } else { | |||
| // Not a valid language | |||
| callback(false, null) | |||
| callback(_loadingLanguage == language, null) | |||
There was a problem hiding this comment.
This fixes an existing race condition of language settings on iOS.
mike-dydx
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, all provider types are enabled, but the client can optionally set the notification types it wants.
This is needed for mobile push notifications where the fills and order status notifications will come from backend instead of Abacus.