Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toInt() crash #448

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Fix toInt() crash #448

merged 5 commits into from
Jun 17, 2024

Conversation

ruixhuang
Copy link
Contributor

I can't find in the current code state where the "null" key can be added. Maybe the root cause has been fixed since the last Android build. Nevertheless adding logic to check for "null" key in the subaccounts map.

@ruixhuang ruixhuang marked this pull request as ready for review June 17, 2024 17:45
@@ -1366,23 +1366,6 @@ open class TradingStateMachine(
)
}

private fun calculateAccount(subaccountNumbers: IList<Int>, period: CalculationPeriod) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

@ruixhuang ruixhuang merged commit 9c3199a into main Jun 17, 2024
4 checks passed
@ruixhuang ruixhuang deleted the feature/toInt branch June 17, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants