feat: enable testnet OTE flows #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogurtandjam
changed the title
yogurtandjam
changed the title
yogurtandjam
force-pushed
the
jerms/QA-route-3
branch
from
2c23b79 to
a3c7126
Compare
rosepuppy
approved these changes
Jun 18, 2024
yogurtandjam
force-pushed
the
jerms/QA-route-2
branch
from
e364db6 to
a891341
Compare
yogurtandjam
force-pushed
the
jerms/QA-route-3
branch
from
2cfcb30 to
3dc6fab
Compare
yogurtandjam
force-pushed
the
jerms/QA-route-2
branch
from
a891341 to
8c85399
Compare
feat: enable withdrawals. also small fixes Bump version cleanup suppression remove squid integrator id check from skip method address detekt complaint cleanup
yogurtandjam
force-pushed
the
jerms/QA-route-3
branch
from
3dc6fab to
33daf47
Compare
yogurtandjam
added a commit
that referenced
this pull request
Jun 19, 2024
yogurtandjam
added a commit
that referenced
this pull request
Jun 19, 2024
yogurtandjam
added a commit
that referenced
this pull request
Jun 21, 2024
yogurtandjam
added a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This doesn't fully enable testnet. We cannot perform withdrawals and deposits. But this is still past parity with existing squid integration as the route endpoint always fails on testnets.
Squid integration: fails on
/v1/route.Withdraw/Depositbutton is never enabled, fees never estimated, just get a route error.Skip Integration (this PR): succeeds on
/msgs_direct, button is enabled, fees estimated. Failure upon clicking the button.