v1.7.75: Add buffer and use oraclePrice to determine collateral movement #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate-oracleprice-and' of github.com:dydxprotocol/v4-abacus into jared/tra-404-update-collateral-calculation-to-incorporate-oracleprice-and
ruixhuang
reviewed
Jun 14, 2024
| // Cap targetLeverage to 98% of max leverage | ||
| val adjustedTargetLeverage = if (maxLeverageForMarket != null) { | ||
| val cappedLeverage = maxLeverageForMarket * MAX_LEVERAGE_BUFFER_PERCENT | ||
| if (targetLeverage > cappedLeverage) { |
There was a problem hiding this comment.
Nit: Can simplify with min()
ruixhuang
reviewed
Jun 14, 2024
| val initialMarginFraction = parser.asDouble(parser.value(market, "configs.initialMarginFraction")) | ||
| val effectiveImf = parser.asDouble(parser.value(market, "configs.effectiveInitialMarginFraction")) | ||
|
|
||
| val maxLeverageForMarket = if (effectiveImf != null) { |
There was a problem hiding this comment.
Safer to check effectiveImf != 0.. Same on the next condition
ruixhuang
approved these changes
Jun 14, 2024
jaredvu
changed the title
jaredvu
deleted the
jared/tra-404-update-collateral-calculation-to-incorporate-oracleprice-and
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AccountTransformercalculateIsolatedMarginTransferAmount. Moved calculation for transfer amount intoMarginModeCalculatorgetShouldTransferCollateralandcalculateIsolatedMarginTranasferAmountMarginModeCalculatorgetIsIncreasingPositionSizewhich is used ingetShouldTransferCollateralcalculateIsolatedMarginTransferAmountwhich caps the targetLeverage to 98% of Max Leverage and returnsgetTransferAmountFromTargetLeverageTradeInputCalculatorISOLATEDswitch cases to return correct valuesgetShouldTransferCollateralto determine whether tocalculateIsolatedMarginTransferAmountsummary.isolatedMarginTransferAmountTradeInputisolatedMarginTransferAmounttoTradeInputSummaryTradingStateMachinesubaccountNumberrequired, it should never be nullSubaccountSupervisortrade.summary.isolatedMarginTransferAmountConstantsMAX_LEVERAGE_BUFFER_PERCENTIsolatedMarginModeTestssummary.isolatedMarginTransferAmountcomparison