feat: top level withdrawal methods [OTE-389] [2/n] #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogurtandjam
force-pushed
the
jerms/OTE-389_top-level-withdrawal-methods
branch
from
13f0b0e to
b62e37b
Compare
yogurtandjam
changed the title
yogurtandjam
force-pushed
the
jerms/QA-route
branch
3 times, most recently
from
aed24dd to
fda7176
Compare
yogurtandjam
commented
Jun 13, 2024
| @@ -141,3 +141,15 @@ fun IMap<String, String>.toUrlParams(): String = | |||
| entries.joinToString("&") { | |||
| it.key + "=" + it.value | |||
| } | |||
|
|
|||
| fun Map<String, Any>.toCamelCaseKeys(): Map<String, Any> { | |||
There was a problem hiding this comment.
if people feel strongly i can write a quick test for this method. i just didn't feel like it was urgently necessary since we test that it works in the SkipRoutePayloadProcessorTests
yogurtandjam
commented
Jun 13, 2024
| @@ -35,3 +35,9 @@ fun String.toDydxAddress(): String? { | |||
| return null | |||
| } | |||
| } | |||
|
|
|||
| fun String.toCamelCase(): String { | |||
yogurtandjam
force-pushed
the
jerms/QA-route
branch
2 times, most recently
from
5c6a01e to
4c2d251
Compare
Base automatically changed from
jerms/OTE-389_top-level-withdrawal-methods
to
main
June 14, 2024 17:42
yogurtandjam
force-pushed
the
jerms/QA-route
branch
2 times, most recently
from
2ec5e2a to
7892452
Compare
yogurtandjam
changed the title
yogurtandjam
commented
Jun 18, 2024
| // skip does not provide the 0x prefix. it's not required but is good for clarity | ||
| // and keeps our typing honest (we typecast this value to evmAddress in web) | ||
| modified.safeSet("data", "0x$data") | ||
| } | ||
| if (txType == TxType.COSMOS) { |
There was a problem hiding this comment.
[fix] early return on data being null
There was a problem hiding this comment.
^ ah this is actually incorrect. cosmos tx do not depend on the data key.
rosepuppy
approved these changes
Jun 18, 2024
feat: enable withdrawals. also small fixes Bump version cleanup suppression remove squid integrator id check from skip method address detekt complaint cleanup
yogurtandjam
force-pushed
the
jerms/QA-route
branch
from
8c03689 to
f1ea6bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #417
withdrawals weren't fully enabled due to additional flows we hadn't accounted for.
also fixes some small bugs and cleans up some unused comments, suppressions, etc.
Performed QA on several flows e2e with this PR.
QA'd Flows:
TODO QA: