fix: orderbook calculation bugs, expose more data #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
src/commonMain/kotlin/exchange.dydx.abacus/processor/markets/OrderbookProcessor.kt
Outdated
Show resolved
Hide resolved
src/commonMain/kotlin/exchange.dydx.abacus/processor/markets/OrderbookProcessor.kt
Show resolved
Hide resolved
| @@ -510,43 +517,55 @@ internal class OrderbookProcessor(parser: ParserProtocol) : BaseProcessor(parser | |||
| } | |||
|
|
|||
| fun group(orderbook: List<Any>?, grouping: Double): List<Any>? { | |||
| return if (orderbook != null && orderbook.size > 0) { | |||
| return if (!orderbook.isNullOrEmpty()) { | |||
There was a problem hiding this comment.
[discussion/suggestion] IMO this is one those functions that has enough math and logic where it makes sense to test separately. we should probably be actively testing edge cases and difficult to reason-about situations like stuff that's been commented here.
i tried to start a pattern with adding the processor tests to the commonTest folder.
There was a problem hiding this comment.
I think the existing orderbook tests hit the main points pretty well............and I feel like it would take me forever to set up new tests.
There was a problem hiding this comment.
Yeah the orderbook tests basically hit this directly
yogurtandjam
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.