Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate FOK #411

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Deprecate FOK #411

merged 3 commits into from
Jun 3, 2024

Conversation

aforaleka
Copy link
Contributor

deprecating FOK since protocol is removing FOK in v6

  • abacus will remove FOK as a timeInForce / execution option
  • note: there's one FOK mention left in abacus as localized string of the timeInForceStringKey, I'm leaving it in as we still want to show that as order details if trader submits it via API and checks it on the FE

prashanDYDX
prashanDYDX approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@prashanDYDX prashanDYDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could maybe also use this opportunity to move checks on "IOC" string to the enum, but up to your judgment based on effort

@aforaleka aforaleka merged commit 7eb2bd4 into main Jun 3, 2024
4 checks passed
@aforaleka aforaleka deleted the deprecate-fok branch June 3, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanDYDX prashanDYDX prashanDYDX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aforaleka @prashanDYDX