Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip route + msgs [OTE-348] #410

Closed
wants to merge 0 commits into from

Conversation

yogurtandjam
Copy link
Contributor

@yogurtandjam yogurtandjam commented Jun 1, 2024

implements skip replacement for squid /route endpoint

This PR implements the skip analog of squid's /route endpoint by utilizing Skip's msgs_direct endpoint.

In order to do this we:

  • Implemented the receivedRoute method on the SkipProcessor
  • Implemented the receivedRouteV2 method on the SkipProcessor
  • Created and implemented the `SkipRouteProcesor
  • Created and implemented the SkipRoutePayloadProcessor

Skip does not provide all the same data that Squid does, so we did our best to keep the data format as similar as possible. We'll have to make some updates on the web side to handle these changes though. Most notably:

  • gasLimit should no longer be required

Some things to cleanup after this PR:

  • errors property is set in a pretty hacky way to coerce the skip payload to mimic squid's. this is intentional to reduce the # of breaking internal API changes. We can migrate that after we confirm core functionality works.
  • slippage is just hard coded. we made sure that the input param for the skip payload is synced with the processor but we should be updating this value all across the codebase. this will be a separate PR as it's not directly related to this functionality
  • there's still some shared logic we may want to deduplicate from squid and skip (TBD. since we're removing squid it may not be worth it)

Future architectural things:

  • i don't think we should be imputing the to and from addresses. we'd be able to easily dedupe a lot more code if we depended on the users dispatching the toAddress toTokenDenom toChainId transferType etc. in the transfer request.

Copy link

linear bot commented Jun 1, 2024

@yogurtandjam yogurtandjam changed the base branch from main to jerms/OTE-351_router-version-env-flag June 1, 2024 02:29
@yogurtandjam yogurtandjam force-pushed the jerms/OTE-348_skip-route-msgs branch from 85e8a00 to 2865509 Compare June 4, 2024 08:54
@yogurtandjam yogurtandjam marked this pull request as ready for review June 4, 2024 08:57
@yogurtandjam yogurtandjam force-pushed the jerms/OTE-348_skip-route-msgs branch 4 times, most recently from 2be35aa to 223d367 Compare June 4, 2024 22:25
@yogurtandjam yogurtandjam force-pushed the jerms/OTE-351_router-version-env-flag branch from 7b57029 to 00ae245 Compare June 5, 2024 15:02
Base automatically changed from jerms/OTE-351_router-version-env-flag to main June 5, 2024 15:02
@yogurtandjam yogurtandjam force-pushed the jerms/OTE-348_skip-route-msgs branch from 4330844 to 4a96bef Compare June 5, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant