create memo field for transferInput #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moo-onthelawn
commented
May 30, 2024
| @@ -25,6 +25,7 @@ enum class TransferInputField(val rawValue: String) { | |||
| chain("chain"), | |||
| token("token"), | |||
| address("address"), | |||
| MEMO("memo"), | |||
There was a problem hiding this comment.
lol this is for linting purposes, but yeah the other enum vals should be renamed at some point (would rather not incorporate into this PR)
rosepuppy
approved these changes
May 30, 2024
yogurtandjam
pushed a commit
to Ryz0nd/v4-abacus
that referenced
this pull request
May 31, 2024
Co-authored-by: mobile-build-bot-git <[email protected]>
yogurtandjam
pushed a commit
that referenced
this pull request
May 31, 2024
Co-authored-by: mobile-build-bot-git <[email protected]>
yogurtandjam
pushed a commit
that referenced
this pull request
May 31, 2024
Co-authored-by: mobile-build-bot-git <[email protected]>
yogurtandjam
pushed a commit
that referenced
this pull request
May 31, 2024
Co-authored-by: mobile-build-bot-git <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filled out
TransferInput.mda bit more (it's outdated)add
memotoTransferInput; clear it when transfer type switches (but maintain it between token type switches)I considered adding a
needsMemofield to the different transfer type options (WithdrawalInputOptions, etc) but that seemed like overkill when the caller can just conditionally render the memo field depending on type - and maybe we'd want to allow users to fill in a memo in other cases in the future?Tested with tests; built locally
Screen.Recording.2024-05-30.at.3.11.39.PM.mov