Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: routerVendor variable [OTE-351] #398

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

yogurtandjam
Copy link
Contributor

@yogurtandjam yogurtandjam commented May 29, 2024

this PR:

  • adds routerVendor variable to determine whether to use squid or skip
  • creates useSkip input param for perpetual state machine. this isn't ideal, but it's okay because:
    • we'll be removing this code fairly soon anyway
    • we can't pass in the routerVendor variable all the way in because there's a different enum for V2 and V1 abacus
  • updates base router interface to use new internal state properties
  • updates all references to squidProcess -> routerProcessor
  • adds tests to ensure that tradingstatemachine constructs the correct processor
  • defaults to using Squid
  • does NOT use the useSkip variable yet to branch squid vs skip codepaths in the StateAdaptor. This is because we can't reliably test that code branching yet.

NOTE: i'd really like to add mockk so we can test that the OnboardingSupervisor is calling the correct methods for squid vs skip branching so I can feel really confident about the branching logic for what API to call

that will be a followup PR to this.

@yogurtandjam yogurtandjam changed the base branch from main to jerms/OTE-346_skip-assets May 30, 2024 04:07
@yogurtandjam yogurtandjam force-pushed the jerms/OTE-351_router-version-env-flag branch from 4ddd482 to 4053711 Compare May 30, 2024 06:29
@yogurtandjam yogurtandjam changed the title feat: routerVendor variable feat: routerVendor variable [OTE-351] May 30, 2024
Copy link

linear bot commented May 30, 2024

@yogurtandjam yogurtandjam force-pushed the jerms/OTE-351_router-version-env-flag branch 5 times, most recently from f7be7b5 to c23310a Compare May 30, 2024 23:59
@yogurtandjam yogurtandjam force-pushed the jerms/OTE-346_skip-assets branch 6 times, most recently from 23e8e79 to abad906 Compare May 31, 2024 23:54
Base automatically changed from jerms/OTE-346_skip-assets to main June 1, 2024 00:36
@yogurtandjam yogurtandjam marked this pull request as ready for review June 1, 2024 02:27
@yogurtandjam yogurtandjam force-pushed the jerms/OTE-351_router-version-env-flag branch from 630b111 to b31f455 Compare June 1, 2024 02:28
Copy link
Contributor

@rosepuppy rosepuppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@yogurtandjam yogurtandjam enabled auto-merge (squash) June 5, 2024 14:50
@yogurtandjam yogurtandjam force-pushed the jerms/OTE-351_router-version-env-flag branch from 7b57029 to 00ae245 Compare June 5, 2024 15:02
@yogurtandjam yogurtandjam merged commit 4a96bef into main Jun 5, 2024
3 of 4 checks passed
@yogurtandjam yogurtandjam deleted the jerms/OTE-351_router-version-env-flag branch June 5, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants