Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publishToMavenLocal #381

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix publishToMavenLocal #381

merged 2 commits into from
May 24, 2024

Conversation

prashanDYDX
Copy link
Contributor

need to create expect/actual for kotlin-inject component creation methods for every final platform. (See kotlin-inject KMP examples.)

https://github.com/evant/kotlin-inject-samples/blob/main/multiplatform/echo/src/macosArm64Main/kotlin/App.macosArm64.kt

@prashanDYDX prashanDYDX force-pushed the prashan/maven-publish-local-fix branch from e0e48bf to 9c711b1 Compare May 23, 2024 19:51
…ect component creation methods for every final platform. (See kotlin-inject KMP examples.)
@prashanDYDX prashanDYDX force-pushed the prashan/maven-publish-local-fix branch from 9c711b1 to e2850fa Compare May 23, 2024 20:02
Copy link
Contributor

@ruixhuang ruixhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot of boilerplate code.

@prashanDYDX
Copy link
Contributor Author

@ruixhuang yeah, it's because KSP support for Kotlin Multiplatform isn't very good. Luckily we shouldn't need to touch this much

@prashanDYDX prashanDYDX merged commit 83d032f into main May 24, 2024
3 checks passed
@prashanDYDX prashanDYDX deleted the prashan/maven-publish-local-fix branch May 24, 2024 22:49
yogurtandjam pushed a commit to Ryz0nd/v4-abacus that referenced this pull request May 31, 2024
yogurtandjam pushed a commit that referenced this pull request May 31, 2024
Co-authored-by: Rui <[email protected]>

fix typo

remove custom setters
yogurtandjam pushed a commit that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants