Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close isolated position #377

Merged
merged 12 commits into from
May 24, 2024
Merged

Close isolated position #377

merged 12 commits into from
May 24, 2024

Conversation

jaredvu
Copy link
Contributor

@jaredvu jaredvu commented May 23, 2024 •
edited
Loading

https://linear.app/dydx/issue/TRA-280/closing-an-isolated-position-with-the-x-button-in-the-positions-table

Fix close position flow

  • Ensure correct subaccountNumber is being used for trading payload
  • replace subaccount with groupedSubaccounts (subaccount still used as fallback when not utilizing v4_parent_subaccount channel)
  • Add tests for closing isolated margin position

@jaredvu jaredvu merged commit 78ecf70 into main May 24, 2024
3 checks passed
@jaredvu jaredvu deleted the close-isolated-position branch May 24, 2024 01:37
@moo-onthelawn moo-onthelawn mentioned this pull request May 28, 2024
Merged
yogurtandjam pushed a commit to Ryz0nd/v4-abacus that referenced this pull request May 31, 2024
@jaredvu @yogurtandjam
Close isolated position (dydxprotocol#377)
2abba71 
Add `cosmosWalletConnected` state

lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanDYDX prashanDYDX prashanDYDX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredvu @prashanDYDX