v1.7.38: Handle channel_batch_data for v4_parent_subaccount #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredvu
changed the title
jaredvu
commented
May 22, 2024
Comment on lines
849
to
859
| @JsExport | ||
| @Serializable | ||
| enum class MarginMode(val rawValue: String) { | ||
| ISOLATED("ISOLATED"), | ||
| CROSS("CROSS"); | ||
|
|
||
| companion object { | ||
| operator fun invoke(rawValue: String) = | ||
| MarginMode.values().firstOrNull { it.rawValue == rawValue } | ||
| } | ||
| } |
There was a problem hiding this comment.
@mike-dydx MarginMode exists in TradeInput.kt, should we remove it there and opt to use the Account.kt one everywhere? We should also wait to rebase over @johnqh 's changes
mike-dydx
force-pushed
the
orders-processor
branch
from
6e630ad to
e6a2cb5
Compare
prashanDYDX
reviewed
May 23, 2024
prashanDYDX
reviewed
May 23, 2024
prashanDYDX
reviewed
May 23, 2024
src/commonMain/kotlin/exchange.dydx.abacus/processor/wallet/account/AccountProcessor.kt
Show resolved
Hide resolved
prashanDYDX
reviewed
May 23, 2024
src/commonMain/kotlin/exchange.dydx.abacus/processor/wallet/account/OrderProcessor.kt
Show resolved
Hide resolved
prashanDYDX
reviewed
May 23, 2024
src/commonMain/kotlin/exchange.dydx.abacus/processor/wallet/account/OrdersProcessor.kt
Show resolved
Hide resolved
prashanDYDX
approved these changes
May 23, 2024
mike-dydx
force-pushed
the
orders-processor
branch
from
a8f476e to
333acfd
Compare
This reverts commit 4fcc9a5.
mike-dydx
force-pushed
the
orders-processor
branch
from
333acfd to
ae5ae7c
Compare
jaredvu
commented
May 24, 2024
v4_abacus.podspec
Outdated
| @@ -1,6 +1,6 @@ | |||
| Pod::Spec.new do |spec| | |||
| spec.name = 'v4_abacus' | |||
| spec.version = '1.7.31' | |||
| spec.version = ''1.7.31' | |||
There was a problem hiding this comment.
hmm seems like an issue with the auto increment
There was a problem hiding this comment.
i probably fat fingered it when entering the value, good catch, updated d417bc7
jaredvu
changed the title
…into orders-processor
jaredvu
changed the title
mike-dydx
reviewed
May 29, 2024
| @@ -329,7 +339,7 @@ class V4ParentSubaccountTests : V4BaseTests(true) { | |||
| "trade": { | |||
| "marginMode": "CROSS", | |||
| "options": { | |||
| "needsMarginMode": false | |||
| "needsMarginMode": true | |||
There was a problem hiding this comment.
@jaredvu do we have a test for when we expect needsMarginMode to be false?
mike-dydx
approved these changes
May 29, 2024
yogurtandjam
pushed a commit
to Ryz0nd/v4-abacus
that referenced
this pull request
May 31, 2024
…ocol#370) Co-authored-by: mike-dydx <[email protected]> Co-authored-by: Rui <[email protected]> Co-authored-by: mobile-build-bot-git <[email protected]> Co-authored-by: mike-dydx <[email protected]>
yogurtandjam
pushed a commit
that referenced
this pull request
May 31, 2024
Co-authored-by: mike-dydx <[email protected]> Co-authored-by: Rui <[email protected]> Co-authored-by: mobile-build-bot-git <[email protected]> Co-authored-by: mike-dydx <[email protected]>
yogurtandjam
pushed a commit
that referenced
this pull request
May 31, 2024
Co-authored-by: mike-dydx <[email protected]> Co-authored-by: Rui <[email protected]> Co-authored-by: mobile-build-bot-git <[email protected]> Co-authored-by: mike-dydx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 fixes included
channel_batch_datafor orders when subscribed tov4_parent_subaccounthassubaccountNumberat the top-level of the contents and not within the list ofordersobject. Re-introducesubaccountNumberto the Order object in Abacus.needsLeverageto false whenTradeInputis set toMarket + Isolated