indexer subaccount order type update #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I defer to @prashanDYDX for typing things in kotlin, but overall looks gouda
| order.side.isOppositeOf(currentSide) | ||
| } ?: false | ||
| } | ||
| val stopLossOrders = triggerOrders?.filter { order -> | ||
| selectedSubaccountPosition?.side?.current?.let { currentSide -> | ||
| (order.type == OrderType.stopMarket || order.type == OrderType.stopLimit) && | ||
| (order.type == OrderType.stopMarket || order.type == OrderType.stopLimit) && order.side != null && |
There was a problem hiding this comment.
could we simplify this to order.side?.isOppositeOf(currentSide)?
There was a problem hiding this comment.
um kinda! can change to order.side?.isOppositeOf(currentSide) == true
| ParsingErrorType.MissingRequiredData, | ||
| "no existing order to be cancelled for $orderId", | ||
| ) | ||
| val marketId = existingOrder.marketId | ||
| val marketId = existingOrder.marketId!! |
There was a problem hiding this comment.
sad that kotlin can't deduce this :'(
aforaleka
force-pushed
the
update-subaccount-order-type
branch
from
603ad00 to
12b47dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indexer will soon send ws msg when cancel is received for non existent order, thus we'll need to update the subaccount order type to handle that scenario
those fields should only really be null when the order is already canceled, so most existing code paths can still expect those fields to be nonnull