Add V4Environment and Documentation to the graph. Pre-req for moving … #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…state-machine components into the graph.
prashanDYDX
force-pushed
the
prashan/immutable-env
branch
from
a70dc10 to
45d155e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…state-machine components into the graph.
This PR does not change how the current Abacus state manager functions. But, it does set the stage for a larger change:
Environment will not be able to be changed at runtime. Instead, clients will have to force restart when changing environments.
Because Environment is used everywhere, supporting mutability in the graph would be a massive refactor. Every place environment is consumed would have to be updated to be reactive, since updating object instances does not work in a DI graph.