Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mob 510 verify isolated position state #357

Merged
merged 4 commits into from
May 14, 2024
Merged

Feature/mob 510 verify isolated position state #357

merged 4 commits into from
May 14, 2024

Conversation

johnqh
Copy link
Contributor

@johnqh johnqh commented May 14, 2024

Fixed a couple of issues

  1. Parsing of orders expected null if there are no orders. Indexer returns an empty object.
  2. Have to use top level subaccountNumber instead of expecting it in each object.

@johnqh johnqh requested a review from jaredvu May 14, 2024 20:59
@linear Linear
Copy link

linear bot commented May 14, 2024

MOB-510 Abacus: verify state with real payload from Indexer

@ruixhuang ruixhuang merged commit 2542f4a into main May 14, 2024
3 checks passed
@ruixhuang ruixhuang deleted the feature/MOB-510-verify-isolated-position-state branch May 14, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredvu jaredvu jaredvu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnqh @jaredvu @ruixhuang