Fix ios podspec #353
Merged
Fix ios podspec #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanDYDX
reviewed
May 14, 2024
| @@ -118,20 +118,6 @@ interface WebSocketProtocol { | |||
| fun send(message: String) | |||
| } | |||
|
|
|||
| @JsExport | |||
| @Serializable | |||
| enum class HistoricalPnlPeriod(val rawValue: String) { | |||
There was a problem hiding this comment.
Did you mean to delete this?
There was a problem hiding this comment.
Yes, it's a duplicated declaration.
prashanDYDX
reviewed
May 14, 2024
Comment on lines
27
to
29
| cd integration/iOS | ||
| pod install No newline at end of file | ||
| pod install |
There was a problem hiding this comment.
Do we need this iOS integration folder? Is it useful / up-to-date?
There was a problem hiding this comment.
Yes, we used that every once a while to test the integration.
prashanDYDX
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest Kotlin MM tooling added a step that causes issue with our iOS build workflow. Updating the bump_version script to remove the step.
Also removing duplicated declaration of HistoricalPnlPeriod (it's also in Settings.kt)