chore: Update SubaccountPosition fields to be non-nullable. #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanDYDX
commented
May 13, 2024
| @@ -228,31 +228,31 @@ data class SubaccountPosition( | |||
| val id: String, | |||
| val assetId: String, | |||
| val side: TradeStatesWithPositionSides, | |||
| val entryPrice: TradeStatesWithDoubleValues?, | |||
| val entryPrice: TradeStatesWithDoubleValues, | |||
| val exitPrice: Double?, | |||
| val createdAtMilliseconds: Double?, | |||
There was a problem hiding this comment.
It feels like this field should always be populated, but not sure if there is a case where it wouldn't be.
prashanDYDX
force-pushed
the
prashan/subaccountposition-nullability
branch
2 times, most recently
from
e674404 to
9ae0456
Compare
ruixhuang
approved these changes
May 13, 2024
prashanDYDX
force-pushed
the
prashan/subaccountposition-nullability
branch
from
9ae0456 to
91f17f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.