Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[analytics] track order status changes #349

Merged
merged 2 commits into from
May 13, 2024
Merged

[analytics] track order status changes #349

merged 2 commits into from
May 13, 2024

Conversation

aforaleka
Copy link
Contributor

@aforaleka aforaleka commented May 10, 2024 •
edited
Loading

  • better tracking of round trip time (e.g. a short term order being filled vs. just indexed)
  • also useful for other future tracking (how often is an order filled during the same FE session)

tested locally:
image

aforaleka
aforaleka commented May 10, 2024
View reviewed changes
src/commonMain/kotlin/exchange.dydx.abacus/state/manager/utils/Payloads.kt
@@ -20,6 +21,7 @@ data class PlaceOrderRecord(
val clientId: Int,
val timestampInMilliseconds: Double,
val fromSlTpDialog: Boolean,
var lastOrderStatus: OrderStatus?,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this.. legal? :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit I wonder if we can just do val lastOrderStatus: OrderStatus? = null

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the main issue is i can't reassign lastOrderStatus if it's val instead of var, but i can add the =null there

moo-onthelawn
moo-onthelawn approved these changes May 10, 2024
View reviewed changes
src/commonMain/kotlin/exchange.dydx.abacus/state/manager/utils/Payloads.kt
@@ -20,6 +21,7 @@ data class PlaceOrderRecord(
val clientId: Int,
val timestampInMilliseconds: Double,
val fromSlTpDialog: Boolean,
var lastOrderStatus: OrderStatus?,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit I wonder if we can just do val lastOrderStatus: OrderStatus? = null

@aforaleka aforaleka force-pushed the track-order-status-changes branch from d1bd0fe to ac7e671 Compare May 13, 2024 15:24
@aforaleka aforaleka merged commit c975816 into main May 13, 2024
3 checks passed
@aforaleka aforaleka deleted the track-order-status-changes branch May 13, 2024 15:28
@aforaleka aforaleka mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moo-onthelawn moo-onthelawn moo-onthelawn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aforaleka @moo-onthelawn