add validator url / network tracking in analytics #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aforaleka
commented
May 8, 2024
•
aforaleka
commented
prashanDYDX
reviewed
May 8, 2024
src/commonMain/kotlin/exchange.dydx.abacus/state/manager/V4StateManagerAdaptor.kt
Outdated
Show resolved
Hide resolved
prashanDYDX
reviewed
May 8, 2024
src/commonMain/kotlin/exchange.dydx.abacus/state/v2/supervisor/NetworkSupervisor.kt
Outdated
Show resolved
Hide resolved
prashanDYDX
reviewed
May 8, 2024
src/commonMain/kotlin/exchange.dydx.abacus/state/v2/supervisor/NetworkSupervisor.kt
Outdated
Show resolved
Hide resolved
aforaleka
force-pushed
the
validator-url-in-order-events
branch
3 times, most recently
from
d446660 to
e6f1313
Compare
aforaleka
force-pushed
the
validator-url-in-order-events
branch
from
99339db to
366f438
Compare
aforaleka
force-pushed
the
validator-url-in-order-events
branch
from
366f438 to
1eefcde
Compare
aforaleka
changed the title
aforaleka
force-pushed
the
validator-url-in-order-events
branch
2 times, most recently
from
5ec5436 to
7151ce6
Compare
aforaleka
force-pushed
the
validator-url-in-order-events
branch
from
7151ce6 to
f27e800
Compare
moo-onthelawn
approved these changes
May 10, 2024
src/commonMain/kotlin/exchange.dydx.abacus/state/v2/supervisor/ConnectionStats.kt
Outdated
Show resolved
Hide resolved
prashanDYDX
reviewed
May 10, 2024
| val interval = if (indexerTime != null) { | ||
| ( | ||
| Clock.System.now().toEpochMilliseconds() | ||
| .toDouble() - indexerTime |
There was a problem hiding this comment.
Why are we using Doubles for epoch milliseconds? Shouldn't we just keep them as Longs to avoid loss of precision?
There was a problem hiding this comment.
errr not sure if there's reason behind it -- can switch to Long here during the subtraction but maybe need to keep them as Doubles when sending to amplitude for consistency?
prashanDYDX
reviewed
May 10, 2024
| val requiredParams = apiStateParams() | ||
| val mergedParams = params?.let { ParsingHelper.merge(params.filterNotNull(), requiredParams) } ?: requiredParams | ||
| val paramsAsString = this.jsonEncoder.encode(mergedParams) | ||
| this.ioImplementations.threading?.async(ThreadingType.main) { |
There was a problem hiding this comment.
why are we running this on main thread?
There was a problem hiding this comment.
@johnqh can u provide context T_T? i dont think web actually does anything different
aforaleka
force-pushed
the
validator-url-in-order-events
branch
from
de5de5e to
ab3a5a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.