feat: add new properties to market [OTE-296] #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogurtandjam
commented
May 2, 2024
| @@ -111,6 +112,8 @@ internal class MarketProcessor(parser: ParserProtocol, private val calculateSpar | |||
| "double" to mapOf( | |||
| "volume24H" to "volume24H", | |||
| "openInterest" to "openInterest", | |||
| "openInterestLowerCap" to "openInterestLowerCap", | |||
| "openInterestUpperCap" to "openInterestUpperCap", | |||
There was a problem hiding this comment.
honestly have no idea what this is for. don't even know if i need this
There was a problem hiding this comment.
This map is used for parsing fields from the API to fields in the abacus state. So adding the keys here lets abacus know to look for these fields
There was a problem hiding this comment.
ah yeah i see now, in private fun perpetual it's used as an input to the transform method. makes sense
prashanDYDX
reviewed
May 2, 2024
prashanDYDX
approved these changes
May 2, 2024
prashanDYDX
reviewed
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Threads in new properties
openInterestLowerCapopenInterestUpperCapso we can use them to calculate the effective IMF