v1.7.24: Add function to reclaim funds #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaredvu
commented
May 1, 2024
•
jaredvu
commented
- Function looks to loop through existing subaccounts to find funds w/o positions/orders. It then initiates a transfer back to the parent subaccount.
- Fix Subaccount initialization to provide correct subaccountNumber
|
Tests? |
johnqh
suggested changes
May 1, 2024
src/commonMain/kotlin/exchange.dydx.abacus/state/v2/supervisor/SubaccountSupervisor.kt
Show resolved
Hide resolved
prashanDYDX
reviewed
May 3, 2024
src/commonMain/kotlin/exchange.dydx.abacus/state/v2/supervisor/SubaccountSupervisor.kt
Outdated
Show resolved
Hide resolved
prashanDYDX
reviewed
May 3, 2024
| helper.ioImplementations.threading?.async(ThreadingType.main) { | ||
| this.reclaimUnutilizedFundsTimer = helper.ioImplementations.timer?.schedule( | ||
| (10.seconds).inWholeSeconds.toDouble(), | ||
| null, |
There was a problem hiding this comment.
can we use this repeat duration instead of recursively calling this function?
There was a problem hiding this comment.
Current recursive implementation waits for a successful callback reponse for each transfer and goes through the entire list of childSubaccounts then creates a fresh 10 sec timer before repeating. I don't think I can achieve the same effect with repeat.
prashanDYDX
reviewed
May 9, 2024
src/commonMain/kotlin/exchange.dydx.abacus/state/v2/supervisor/SubaccountSupervisor.kt
Outdated
Show resolved
Hide resolved
jaredvu
changed the title
jaredvu
changed the title
johnqh
approved these changes
May 17, 2024
…from' of github.com:dydxprotocol/v4-abacus into jared/tra-238-add-function-to-reclaim-unutilized-funds-from
jaredvu
deleted the
jared/tra-238-add-function-to-reclaim-unutilized-funds-from
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.