Create Input for Adjusting Isolated Position's Margin

[jaredvu]

• Add AdjustIsolatedMarginInput InputType and introduced to Input state
• Add commitAdjustIsolatedMargin to initiate transfer between parent and child subaccounts
• Update Input docs
• Added test to check parent and child subaccounts' quoteBalance

[linear]

TRA-183 Abacus: Create Input for Adjusting Position Margin

[yogurtandjam]

[suggestion] use named args

[prashanDYDX]

can use static imports for Add and Remove specifically to make the code easier to read below.

import exchange.dydx.abacus.output.input.IsolatedMarginAdjustmentType.Add
import exchange.dydx.abacus.output.input.IsolatedMarginAdjustmentType.Remove

[jaredvu]

qq: wdym by easier to read? The import would be easier to read?

[prashanDYDX]

like at usage sites you now get:

when(type) {
  Add -> ...
  Remove -> ...
}

[jaredvu]

Wow that's pretty cool! I don't have a preference on either though. With the static import I think we would lose some readability unless you double check the enum, and what happens if there are multiple enums with the same .name

[prashanDYDX]

yeah up to you, i don't feel strongly.

re multiple enums: you have to explicitly say what type you're casting the value to, so that ends up not being an issue. ex:

val type = "Add"
when(IsolatedMarginAdjustmentType.valueOf(type)) {
  Add -> ...
  Remove -> ...
}

[prashanDYDX]

This is purely used by clients right? so can use built-in conversion? i guess you'd run into the enum naming rule (maybe disable?)