v1.6.53: add analytics for SL/TP

[moo-onthelawn]

Summary of Logging Added

1. User clicks submit button on SL/TP
   • We log a TriggerOrderClick event with
     • marketId
     • positionSize: Double
     • [takeProfit/stopLoss]OrderAction: 'CREATE' | 'CANCEL' | 'REPLACE' | null (if no action)
     • [takeProfit/stopLoss]Order[Cancel/Place]ClientId: Int
2. Trade[Cancel/Place]Order logged with existing params and fromSlTpDialog: true
3. If successful:
   • Trade[Cancel/Place]OrderConfirmed logged with existing params and fromSlTpDialog: true
   • Trade[Cancel/Place]OrderSubmissionConfirmed logged with existing params and fromSlTpDialog: true
4. If unsuccessful, Trade[Cancel/Place]OrderFailed logged with existing params and fromSlTpDialog: true

Testing

Built locally on web and logged output.

2x create	2x cancel	2x replace	1x replace, 1x no action

Code

1. Add more thorough logging for SL/TP
2. Distinguish trade log events from SL/TP log events:
   • Action: Click "place orders" on SL/TP dialog
     New behavior: single TriggerOrderClick fired
     Old behavior: TradePlaceOrder and TradeCancelOrder fired
   • Action: Trade submit (for logging times)
     New behavior: TradePlaceOrder/TradeCancelOrder with fromSlTp: true
   • Action: Trade successfully submitted (for logging times)
     New behavior: TradePlaceOrderSubmissionConfirmed /TradeCancelOrderSubmissionConfirmed with fromSlTp: true
   • Action: Trade failed to submit (for logging times)
     New behavior: TradePlaceOrderSubmissionFailed /TradeCancelOrderSubmissionFailed with fromSlTp: true
   • Action: parsing place/cancel order records
     New behavior: TradeCancelOrderConfirmed /TradePlaceOrderConfirmed with fromSlTp: true
3. Create a new triggerOrdersAnalyticsPayload
   • Only used in the TriggerOrderClick event; other events continue to use placeOrderAnalyticsPayload/cancelOrderAnalyticsPayload
   • Tracks marketId, (total)PositionSize, stopLossOrderAction/takeProfitOrderAction (REPLACE / CANCEL / CREATE), stopLossOrder[Cancel/Place]ClientId, takeProfitOrder[Cancel/Place]ClientId
4. Update existing payloads with more data for analytics
   • PlaceOrderRecord/CancelOrderRecord: added fromSlTp to pass to Trade[Cancel/Place]OrderConfirmed
   • HumanReadableTriggerOrdersPayload: add marketId, positionSize for triggerOrdersAnalyticsPayload
   • HumanReadableCancelOrderPayload: add type

[linear]

CT-783 new analytics clickevent for SL/TP

[prashanDYDX]

kotlin tip: we can instead enforce triggerOrders is non-null by doing:
val triggerOrders = requireNotNull(stateMachine.state?.input?.triggerOrders) { "triggerOrders input was null" }

then we don't need to do null checks on it later.

[moo-onthelawn]

part of me wants to write a codemod to go through the whole repo to replace all of the throwExceptions

[prashanDYDX]

.invoke() can be called like a constructor: OrderType(placePayload.type)

[prashanDYDX]

why is this cast necessary?

[moo-onthelawn]

ah good point - should be fine if I just update the return type to be IMap<String, Any?>

[moo-onthelawn]

oh actually I see why we have all these casts in the file - it's because ParsingHelper.merge expects and returns Map<String, Any>? instead of Map<String, Any?>. Given how widely this is used, it seems like a pretty beefy change to fix, so I might just keep it like this for now 😢

[prashanDYDX]

I missed this before, why are we converting these timestamps to Double? Shouldn't we be using Long?

[moo-onthelawn]

hmm unsure - this is just the existing pattern; cc @aforaleka who may have more context (I think you added these values for analytics?)

[yang-dydx]

i only looked at the screenshots and the output looks good from analytics perspective